Re: [Xen-devel] [PATCH 5/9] x86/mtrr: drop unused is_cpu() macro

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.08.16 at 01:28, <cardoe@xxxxxxxxxx> wrote:
> --- a/xen/arch/x86/cpu/mtrr/generic.c
> +++ b/xen/arch/x86/cpu/mtrr/generic.c
> @@ -520,7 +520,7 @@ int mtrr_generic_validate_add_page(unsigned long base, 
> unsigned long size, unsig
>  
>       /*  For Intel PPro stepping <= 7, must be 4 MiB aligned 
>           and not touch 0x70000000->0x7003FFFF */
> -     if (is_cpu(INTEL) && boot_cpu_data.x86 == 6 &&
> +     if (boot_cpu_data.x86 == 6 &&
>           boot_cpu_data.x86_model == 1 &&
>           boot_cpu_data.x86_mask <= 7) {
>               if (base & ((1 << (22 - PAGE_SHIFT)) - 1)) {

Well, this check then was and is (a) wrong (regardless of the MTRR
flavor used the family/model/stepping check has to be CPU vendor
specific) and (b) dead code (we don't run on PPro-s anymore).
Please instead delete it altogether.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel