Re: [Xen-devel] [PATCH v3 31/38] altp2m: Introduce altp2m_switch_vcpu_altp2m_by_id

[Julien Grall <julien.grall@xxxxxxx>]

On 17/08/16 13:37, Sergej Proskurin wrote:
> On 08/17/2016 12:05 PM, Jan Beulich wrote:
> > > > > On 17.08.16 at 00:17, <proskurin@xxxxxxxxxxxxx> wrote:
> > >  xen/arch/arm/altp2m.c        | 32 ++++++++++++++++++++++++++++++++
> > >  xen/arch/x86/mm/altp2m.c     |  6 ++++++
> > >  xen/arch/x86/mm/p2m.c        |  6 ------
> > >  xen/common/vm_event.c        |  3 ++-
> > >  xen/include/asm-arm/altp2m.h |  7 ++++---
> > >  xen/include/asm-arm/p2m.h    |  6 ------
> > >  xen/include/asm-x86/altp2m.h |  3 +++
> > >  xen/include/asm-x86/p2m.h    |  3 ---
> > >  8 files changed, 47 insertions(+), 19 deletions(-)
> > The x86 parts of the change look really independent of the rest, so
> > you could have done yourself a favor by splitting this out, as then
> > the individual patches would each require separate acks rather than
> > the one patch here requiring an x86/mm one along with the ARM and
> > VM-event ones.
> >
> > Jan
> Ok, I will split the patch accordingly. Thank you.
I think it is worth to mention again that patches doing one logical 
thing (i.e moving code, renaming function) are easier to review compare 
to patch doing multiple one.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel