Re: [Xen-devel] [PATCH 3/4] x86emul: drop SrcInvalid

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 15/08/16 09:35, Jan Beulich wrote:
> As of commit a800e4f611 ("x86emul: drop pointless and add useful
> default cases") we no longer need the early bailing when "d == 0" (the
> default cases in the main switch() statements take care of that),
> removal of which renders internal_error() wrong and SrcInvalid useless.

"the removal of which".

However, SrcInvalid is already unused, irrespective of internal_error().

I don't however see how this renders internal_error() incorrect.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel