Re: [Xen-devel] [PATCH] xl cpupool-numa-split: don't try to bring any dom0 vCPUs online

[Juergen Gross <jgross@xxxxxxxx>]

On 12/08/16 15:11, Jonathan Davies wrote:
> Since commit a9dd01431a799b6743193a75f4f1ce2fdfdb7296, main_cpupoolnumasplit
> wants to ensure that dom0 doesn't have more online vCPUs than the number of
> pCPUs in a NUMA node.
> 
> However, if dom0 already has fewer online vCPUs than the number of pCPUs in a
> NUMA node, this will cause some to be made online.
> 
> Furthermore, if dom0's maximum number of vCPUs is less than the number of 
> pCPUs,
> this will result in an error like the following:
> 
>     libxl: error: libxl.c:5564:libxl_set_vcpuonline: Requested 24 VCPUs, 
> however maxcpus is 12!: Function not implemented
>     error on removing vcpus for Domain-0
> 
> Instead, make main_cpupoolnumasplit only reduce the number of vCPUs dom0 has
> online, and don't try to add any more.
> 
> This incurs an extra call to libxl_domain_info to find out the current number 
> of
> dom0 vCPUs. Conveniently, there is already an initialised libxl_dominfo that 
> we
> can use.

Commit c256d2afc1cad0cca912492e338d6ff97e477c4f already corrects this
problem.

Ian, there seems to be some need to backport above commit.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel