Re: [Xen-devel] [PATCH] replace bogus -ENOSYS uses

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 09/08/16 11:40, Jan Beulich wrote:
> --- a/xen/arch/x86/cpu/mtrr/main.c
> +++ b/xen/arch/x86/cpu/mtrr/main.c
> @@ -332,7 +332,7 @@ int mtrr_add_page(unsigned long base, un
>       if ((type == MTRR_TYPE_WRCOMB) && !have_wrcomb()) {
>               printk(KERN_WARNING
>                      "mtrr: your processor doesn't support 
> write-combining\n");
> -             return -ENOSYS;
> +             return -EOPNOTSUPP;

Will this break the classic-xen MTRR code?  ISTR it was very picky, from
the cpuid work.  Also, as some further cleanup, that printk should
become a print-once.

The others look ok.

~Andrew


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel