Re: [Xen-devel] [PATCH 5/7] x86emul: don't special case fetching unsigned 8-bit immediates

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/08/16 13:06, Jan Beulich wrote:
> @@ -2893,7 +2894,6 @@ x86_emulate(
>          goto swint;
>  
>      case 0xcd: /* int imm8 */
> -        src.val = insn_fetch_type(uint8_t);
>          swint_type = x86_swint_int;
>      swint:
>          rc = inject_swint(swint_type, src.val,

I would be tempted to and an explicit (uint8_t) here, so that injection
doesn't break if the prototype of inject_swint() changes.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel