Re: [Xen-devel] [PATCH v4 05/19] x86/boot: call reloc() using stdcall calling convention

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 06.08.16 at 01:04, <daniel.kiper@xxxxxxxxxx> wrote:
> Current reloc() call method makes confusion and does not scale
> well for more arguments. And patch adding multiboot2 protocol
> support have to pass 3 arguments instead of 2. Hence, move reloc()
> call to stdcall calling convention. This way, in comparison to
> cdecl calling convention, we do not need to remove arguments from
> stack in xen/arch/x86/boot/head.S assembly file too.
> 
> Suggested-by: Jan Beulich <jbeulich@xxxxxxxx>
> Signed-off-by: Daniel Kiper <daniel.kiper@xxxxxxxxxx>

Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Albeit I think the commit message could do with some further cleanup.

Jan




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel