Re: [Xen-devel] [PATCH 4/7] x86emul: fold SrcImmByte fetching

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 11/08/16 13:05, Jan Beulich wrote:
> There's no need for having identical code spelled out twice.
>
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxx>
>
> --- a/xen/arch/x86/x86_emulate/x86_emulate.c
> +++ b/xen/arch/x86/x86_emulate/x86_emulate.c
> @@ -1979,9 +1979,12 @@ x86_emulate(
>              goto done;
>          break;
>      case SrcImm:
> +        if ( !(d & ByteOp) )
> +            src.bytes = op_bytes != 8 ? op_bytes : 4;
> +        else

{

> +    case SrcImmByte:
> +            src.bytes = 1;

}

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel