Re: [Xen-devel] [PATCH] common: clean up taint logic

[George Dunlap <george.dunlap@xxxxxxxxxx>]

On 09/08/16 15:06, Jan Beulich wrote:
>>>> On 09.08.16 at 15:16, <george.dunlap@xxxxxxxxxx> wrote:
>> On 09/08/16 11:39, Jan Beulich wrote:
>>> --- a/xen/common/kernel.c
>>> +++ b/xen/common/kernel.c
>>> @@ -22,8 +22,6 @@
>>>  
>>>  enum system_state system_state = SYS_STATE_early_boot;
>>>  
>>> -int tainted;
>>> -
>>>  xen_commandline_t saved_cmdline;
>>>  
>>>  static void __init assign_integer_param(
>>> @@ -168,14 +166,15 @@ int __init parse_bool(const char *s)
>>>      return -1;
>>>  }
>>>  
>>> +unsigned int tainted;
>>> +
>>>  /**
>>>   *      print_tainted - return a string to represent the kernel taint 
>>> state.
>>>   *
>>> - *  'S' - SMP with CPUs not designed for SMP.
>>> - *  'M' - Machine had a machine check experience.
>>> - *  'B' - System has hit bad_page.
>>>   *  'C' - Console output is synchronous.
>>> + *  'E' - An error (e.g. a machine check exceptions) has been injected.
>>>   *  'H' - HVM forced emulation prefix is permitted.
>>> + *  'M' - Machine had a machine check experience.
>>
>> The wording here seems to imply that M -> E; but I don't see anything
>> which adds ERROR_INJECT.  Are you  planning on adding this at some point
>> in the future?
> 
> Did you grep the tree? I find two uses of ERROR_INJECT when I do.

Oh right -- I didn't because it looked like you were adding ERROR_INJECT
as a new #define; I see now you're just redefining it.

Everything looks correct then:

Acked-by: George Dunlap <george.dunlap@xxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel