Re: [Xen-devel] [PATCH v2 06/23] acpi/hvmloader: Collect processor and NUMA info in hvmloader

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 04.08.16 at 23:06, <boris.ostrovsky@xxxxxxxxxx> wrote:
> ---
> v2:
> * Note: struct acpi_numa's pointers can't be constified due to their
>   use in later patches

Well, I hope I'll remember once I get there.

> --- a/tools/firmware/hvmloader/acpi/build.c
> +++ b/tools/firmware/hvmloader/acpi/build.c
> @@ -70,7 +70,8 @@ static void set_checksum(
>      p[checksum_offset] = -sum;
>  }
>  
> -static struct acpi_20_madt *construct_madt(struct acpi_info *info)
> +static struct acpi_20_madt *construct_madt(struct acpi_config *config,

const? (I'm btw going to take the liberty to fix up patch 2 in this
regard when committing it later today, and patch 4 would need
this too then for construct_secondary_tables().)

> @@ -134,9 +135,9 @@ static struct acpi_20_madt *construct_madt(struct 
> acpi_info *info)
>      io_apic->ioapic_addr = IOAPIC_BASE_ADDRESS;
>  
>      lapic = (struct acpi_20_madt_lapic *)(io_apic + 1);
> -    info->nr_cpus = hvm_info->nr_vcpus;
> +    info->nr_cpus = config-> hvminfo->nr_vcpus;

Stray blank. This wouldn't have happened had you introduced a local
variable hvm_info.

> @@ -195,7 +196,7 @@ static struct acpi_20_waet *construct_waet(void)
>      return waet;
>  }
>  
> -static struct acpi_20_srat *construct_srat(void)
> +static struct acpi_20_srat *construct_srat(struct acpi_config *config)

const again?

> @@ -252,12 +254,12 @@ static struct acpi_20_srat *construct_srat(void)
>      return srat;
>  }
>  
> -static struct acpi_20_slit *construct_slit(void)
> +static struct acpi_20_slit *construct_slit(struct acpi_config *config)

And again.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel