Re: [Xen-devel] [PATCH v2 07/25] arm/altp2m: Add altp2m init/teardown routines.

[Sergej Proskurin <proskurin@xxxxxxxxxxxxx>]

Hi Julien,


>>> @@ -1460,7 +1469,16 @@ static int p2m_init_hostp2m(struct domain *d)
>>>
>>>  int p2m_init(struct domain *d)
>>>  {
>>> -    return p2m_init_hostp2m(d);
>>> +    int rc;
>>> +
>>> +    rc = p2m_init_hostp2m(d);
>>> +    if ( rc )
>>> +        return rc;
>>> +
>>> +    if ( altp2m_enabled(d) )
>> I am a bit skeptical that you can fully use altp2m with this check.
>> p2m_init is created at the very beginning when the domain is
>> allocated. So the HVM_PARAM_ALTP2M will not be set.
>>
> I will respond to this answer, after I have made sure this is the case.
> You are right, the need for this call depends on which point in the
> domain initialization process libxl sets the parameter HVM_PARAM_ALTP2M.
> Thank you.
>

You were right. I have removed this check from the next patch series.
Thank you.

Best regards,
~Sergej


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel