Re: [Xen-devel] [OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build

[Ian Jackson <ian.jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[OSSTEST PATCH RFC 06/14] Introduce ts-xtf-build"):
> Clone, build and package XTF for later use.
...
> diff --git a/ts-xtf-build b/ts-xtf-build
> new file mode 100755
> index 0000000..5c4c3ec
> --- /dev/null
> +++ b/ts-xtf-build
...
> +selectbuildhost(\@ARGV);
> +# remaining arguments are passed as targets to "make"

This doesn't seem to be actually true.

> +    target_cmd_build($ho, 300, $builddir, <<END);
> +        cd xtf
> +        rm -f ../xtf-build-ok-stamp
> +        ( make xtfdir=$xtfdir 2>&1 && touch ../xtf-build-ok-stamp
> +        ) |tee ../xtf-build-log
> +        test -f ../xtf-build-ok-stamp

I think you should lift buildcmd_stamped_logged out of ts-xen-build.

> +#/;

These are for the benefit of some editor's indenting ?

> +sub stash () {
> +    built_stash($ho, $builddir, "xtfdist", "xtfdist");
> +}

Can you post a tar zvvtf of a sample xtfdist tarball ?

Thanks,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel