Re: [Xen-devel] [PATCH RFC 01/12] x86/paging: introduce paging_set_allocation

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 03.08.16 at 18:24, <roger.pau@xxxxxxxxxx> wrote:
> On Wed, Aug 03, 2016 at 10:15:51AM -0600, Jan Beulich wrote:
>> >>> On 03.08.16 at 18:00, <roger.pau@xxxxxxxxxx> wrote:
>> > --- a/xen/include/asm-x86/event.h
>> > +++ b/xen/include/asm-x86/event.h
>> > @@ -23,6 +23,10 @@ int hvm_local_events_need_delivery(struct vcpu *v);
>> >  static inline int local_events_need_delivery(void)
>> >  {
>> >      struct vcpu *v = current;
>> > +
>> > +    if ( is_idle_vcpu(v) )
>> > +        return 0;
>> 
>> As said, I think it would be better to not add it here, unless there
>> is a significant amount of other calls into here from idle vCPU-s
>> with your changes.
> 
> No, the only functions that I use that call hypercall_preempt_check are the 
> _set_allocation ones. I would like to add an ASSERT here to make sure 
> local_events_need_delivery is not called with current == idle_vcpu.

That's fine with me.

> In any case, I would go with route 2 and modify _set_allocation to call 
> softirq_pending instead of hypercall_preempt_check if current == idle_vcpu. 
> This should solve the issue and doesn't involve changing 
> hypercall_preempt_check itself.

Thanks.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel