Re: [Xen-devel] [PATCH v2] hvmloader: don't hard-code IO-APIC parameters

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 03/08/16 14:58, Jan Beulich wrote:
> @@ -185,6 +188,14 @@ static void init_vm86_tss(void)
>  
>  static void apic_setup(void)
>  {
> +    /*
> +     * This would the The Right Thing To Do (tm), if only qemu
> +     * negotiated with Xen where the IO-APIC actually sits. Uncomment
> +     * this code once that is the case.

I would possibly extend the text with "This is currently hard coded in
Xen and can't be controlled externally."

Either way, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

> +    ioapic_base_address |= (pci_readb(PCI_ISA_DEVFN, 0x80) & 0x3f) << 10;
> +     */
> +    ioapic_version = ioapic_read(0x01) & 0xff;
> +
>      /* Set the IOAPIC ID to the static value used in the MP/ACPI tables. */
>      ioapic_write(0x00, IOAPIC_ID);
>  

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel