Re: [Xen-devel] [PATCH V3 2/4] xen: Add generic implementation of binary search

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 20.07.16 at 16:00, <shankerd@xxxxxxxxxxxxxx> wrote:
> This patch adds the generic implementation of binary search algorithm
> which is copied from Linux kernel v4.7-rc7. No functional changes.

The last sentence looks wrong in this context.

> --- a/xen/common/Makefile
> +++ b/xen/common/Makefile
> @@ -43,6 +43,7 @@ obj-y += schedule.o
>  obj-y += shutdown.o
>  obj-y += softirq.o
>  obj-y += sort.o
> +obj-y += bsearch.o
>  obj-y += smp.o
>  obj-y += spinlock.o
>  obj-y += stop_machine.o

Please don't break the (mostly) alphabetical ordering here.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel