Re: [Xen-devel] [PATCH v2 5/6] xen/arm: traps: Avoid unnecessary VA -> IPA translation in abort handlers

[Julien Grall <julien.grall@xxxxxxx>]

On 27/07/16 18:28, Sergej Proskurin wrote:
> Hi Julien,
Hello Sergej,

Please reply to all (or at least CC me) when answering to xen-devel. 
Otherwise your mail may be missed or the answer may be delayed because I 
filter any mail where I am not the recipients (a lot of people do this 
on the ML).
> On 07/27/2016 07:09 PM, Julien Grall wrote:
> > @@ -2442,7 +2458,7 @@ static void do_trap_data_abort_guest(struct cpu_user_regs 
> > *regs,
> >      info.gva = READ_SYSREG64(FAR_EL2);
> >  #endif
> >
> > -    if ( dabt.s1ptw )
> > +    if ( hpfar_is_valid(hsr.iabt.s1ptw, fsc) )
> I belive this should be:
>
> hpfar_is_valid(hsr.*dabt*.s1ptw, fsc)
You are right, I did not spot it during my testing because the field is 
exactly the same bits in the HSR.
> >          info.gpa = get_faulting_ipa(info.gva);
> >      else
> >      {
> > @@ -2451,7 +2467,7 @@ static void do_trap_data_abort_guest(struct cpu_user_regs 
> > *regs,
> >              return; /* Try again */
> >      }
> >
> > -    switch ( dabt.dfsc & ~FSC_LL_MASK )
> > +    switch ( fsc )
> >      {
> >      case FSC_FLT_PERM:
> >      {
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel