[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [XTF PATCH v3] Correct the usage of $(DESTDIR) and $(PREFIX)



On Mon, Jul 25, 2016 at 05:23:18PM +0100, Andrew Cooper wrote:
> The GNU coding standards expect $(DESTDIR) to be the root of everything
> installed, and for $(PREFIX) to then be added to the path.  This is not how
> XTF previously behaved.
> 
> XTF is not a typical package, and doesn't meet the usual semantics; it expects
> to arrange all files in a single directory.  Drop the use of $(PREFIX)
> entirely (to avoid the expectation that it behaves as $(prefix) usually
> behaves) and introduce $(xtfdir) instead.
> 
> $(DESTDIR) now works as intended for staged installes, and $(xtfdir) is the
> single selected directy containing all installed content, typically expected
> to be /opt/xtf or similar.
> 
> The intended way to install XTF now:
> 
>   $ make install DESTDIR=/path/to/staging/area xtfdir=/opt/xtf
> 
> Reported-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> Signed-off-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

This code does what the commit message says:

Reviewed-by: Wei Liu <wei.liu2@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.