Re: [Xen-devel] [PATCH v5] altp2m: Allow shared entries to be copied to altp2m views during lazycopy

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Mon, Jul 25, 2016 at 10:01 AM, George Dunlap
<George.Dunlap@xxxxxxxxxxxxx> wrote:
> On Wed, Jul 20, 2016 at 7:55 PM, Tamas K Lengyel
> <tamas.lengyel@xxxxxxxxxxxx> wrote:
>> Move sharing locks above altp2m to avoid locking order violation and crashing
>> the hypervisor during unsharing operations when altp2m is active.
>>
>> Applying mem_access settings or remapping gfns in altp2m views will
>> automatically unshare the page if it was shared previously. Also,
>> disallow nominating pages for which there are pre-existing altp2m
>> mem_access settings or remappings present. However, allow altp2m
>> to populate altp2m views with shared entries during lazycopy as
>> unsharing will automatically propagate the change to these entries in
>> altp2m views as well.
>
> Oh, one more thing; since you're probably respinning it anyway, could
> you add the following (or something like it) to the changelog:
>
> "While we're here, use the appropriate get_entry() wrappers."
>
> Just to clue people in that the change is cosmetic.
>

Sure, no problem. Is the rest of the patch fine this way from your side?

Thanks,
Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel