Re: [Xen-devel] [PATCH] xen/domctl: Add DOMINFO_hap to xen_domctl_getdomaininfo

[Julien Grall <julien.grall@xxxxxxx>]

Hi Andrew,

On 15/07/16 17:57, Andrew Cooper wrote:
> diff --git a/xen/arch/arm/domctl.c b/xen/arch/arm/domctl.c
> index f61f98a..afa16d8 100644
> --- a/xen/arch/arm/domctl.c
> +++ b/xen/arch/arm/domctl.c
> @@ -14,6 +14,12 @@
>  #include <xsm/xsm.h>
>  #include <public/domctl.h>
>
> +void arch_get_domain_info(const struct domain *d,
> +                          struct xen_domctl_getdomaininfo *info)
> +{
> +    info->flags |= XEN_DOMINF_hap;
> +}
> +
The ARM change looks good to me. I have just one request, would be it 
possible to add a comment in the code explaining why hap is 
unconditionally set? (I.e domains are always using hap on ARM).
With that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

>  long arch_do_domctl(struct xen_domctl *domctl, struct domain *d,
>                      XEN_GUEST_HANDLE_PARAM(xen_domctl_t) u_domctl)
>  {
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel