Re: [Xen-devel] [PATCH V4 10/11] xen/arm: io: Use binary search for mmio handler lookup

[Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>]

Hi Julien,

Are you okay to insert the below two validation checks before inserting 
mmio handler?
void register_mmio_handler(struct domain *d,
                           const struct mmio_handler_ops *ops,
                           paddr_t addr, paddr_t size, void *priv)
{
    struct vmmio *vmmio = &d->arch.vmmio;
    struct mmio_handler *handler;

    /* Don't allow overlap regions */
    BUG_ON(find_mmio_handler(d, addr);
    BUG_ON(find_mmio_handler(d, addr + size - 1);

    BUG_ON(vmmio->num_entries >= vmmio->max_num_entries);

--
Shanker Donthineni
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm 
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux 
Foundation Collaborative Project.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel