Re: [Xen-devel] [PATCH v2] vmx/monitor: CPUID events

[Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>]

On Tue, Jul 12, 2016 at 12:22 PM, Andrew Cooper
<andrew.cooper3@xxxxxxxxxx> wrote:
> On 12/07/16 19:13, Tamas K Lengyel wrote:
>> This patch implements sending notification to a monitor subscriber when an
>> x86/vmx guest executes the CPUID instruction.
>>
>> Signed-off-by: Tamas K Lengyel <tamas.lengyel@xxxxxxxxxxxx>
>
> From an x86 point of view, Reviewed-by: Andrew Cooper
> <andrew.cooper3@xxxxxxxxxx>, with one nit that I can fix on commit if
> needs be.
>
>> @@ -3524,10 +3526,28 @@ void vmx_vmexit_handler(struct cpu_user_regs *regs)
>>          hvm_task_switch((uint16_t)exit_qualification, reasons[source], 
>> ecode);
>>          break;
>>      }
>> -    case EXIT_REASON_CPUID:
>> -        is_pvh_vcpu(v) ? pv_cpuid(regs) : vmx_do_cpuid(regs);
>> -        update_guest_eip(); /* Safe: CPUID */
>> +    case EXIT_REASON_CPUID: {
>
> Brace on a newline here.

Sure, though both styles are used interchangeably throughout vmx.c

Tamas

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel