Re: [Xen-devel] [PATCH v6 06/14] xen: Move the hvm_start_info C representation from libxc to public/xen.h

[Anthony PERARD <anthony.perard@xxxxxxxxxx>]

On Tue, Jul 12, 2016 at 04:09:59PM +0100, Andrew Cooper wrote:
> On 12/07/16 15:42, Anthony PERARD wrote:
> > +#ifndef __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__
> > +#define __XEN_PUBLIC_ARCH_X86_HVM_START_INFO_H__
> > +
> > +/*
> > + * C representation of the x86/HVM start info layout.
> > + *
> > + * The canonical definition of this layout resides in public/xen.h, this
> 
> You should also move the big comment block from public/xen.h to here,
> along with the XEN_HVM_START_MAGIC_VALUE define.

Is it fine to move the comment and the define even if there has been one
release of Xen with this in xen.h?

> There is no point having it split across two locations in the public
> headers.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel