Re: [Xen-devel] [PATCH v6 12/14] xen/arm: p2m: Introduce helpers to insert and remove mapping

[Julien Grall <julien.grall@xxxxxxx>]

Hi,

On 06/07/16 14:01, Julien Grall wrote:
>   int map_mmio_regions(struct domain *d,
> @@ -1189,12 +1207,8 @@ int map_mmio_regions(struct domain *d,
>                        unsigned long nr,
>                        mfn_t mfn)
>   {
> -    return apply_p2m_changes(d, INSERT,
> -                             pfn_to_paddr(gfn_x(start_gfn)),
> -                             pfn_to_paddr(gfn_x(start_gfn) + nr),
> -                             pfn_to_paddr(mfn_x(mfn)),
> -                             MATTR_DEV, 0, p2m_mmio_direct,
> -                             d->arch.p2m.default_access);
> +    return p2m_insert_mapping(d, start_gfn, nr, mfn,
> +                              MATTR_MEM, p2m_mmio_direct);
This should be MATTR_DEV and not MATTR_MEM. I will fix it in the next 
version.
>   }
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel