Re: [Xen-devel] [PATCH v1 06/20] acpi/hvmloader: Collect processor and NUMA info in hvmloader

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/08/2016 09:36 AM, Jan Beulich wrote:
>
>> @@ -51,6 +53,14 @@ struct acpi_info {
>>      uint64_t pci_hi_min, pci_hi_len; /* 24, 32 - PCI I/O hole boundaries */
>>  };
>>  
>> +struct acpi_numa {
>> +    uint32_t nr_vmemranges;
>> +    uint32_t nr_vnodes;
>> +    unsigned int *vcpu_to_vnode;
>> +    unsigned int *vdistance;
>> +    xen_vmemrange_t *vmemrange;
> ... you use struct xen_vmemrange * here.
>
> Also I think the two pointed to types can and should be const
> qualified.
>
> And then - any reason not to put this ...
>
>> @@ -66,6 +76,9 @@ struct acpi_config {
>>          uint32_t pt_length;
>>      } pt;
>>  
>> +    struct acpi_numa numa;
> ... right here, perhaps even omitting the structure tag?

I'd like to have a data type for better readability. See patch 20,
init_acpi_config().

-boris



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel