Re: [Xen-devel] [PATCH v1 09/20] acpi/hvmloader: Build WAET optionally

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.16 at 21:05, <boris.ostrovsky@xxxxxxxxxx> wrote:
> --- a/tools/firmware/hvmloader/acpi/build.c
> +++ b/tools/firmware/hvmloader/acpi/build.c
> @@ -342,9 +342,12 @@ static int construct_secondary_tables(unsigned long 
> *table_ptrs,
>      }
>  
>      /* WAET. */
> -    waet = construct_waet();
> -    if (!waet) return -1;
> -    table_ptrs[nr_tables++] = (unsigned long)waet;
> +    if ( config->table_flags & ACPI_BUILD_WAET )
> +    {
> +        waet = construct_waet();
> +        if ( !waet ) return -1;

Now that you touch it, this should become two lines. With that
Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel