Re: [Xen-devel] [PATCH v1 04/20] acpi/hvmloader: Decide which SSDTs to install in hvmloader

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 05.07.16 at 21:05, <boris.ostrovsky@xxxxxxxxxx> wrote:
> @@ -890,6 +895,13 @@ void hvmloader_acpi_build_tables(struct acpi_config 
> *config,
>              config->vm_gid[1] = strtoll(end+1, NULL, 0);
>      }
>  
> +    if ( battery_port_exists() )
> +        config->table_flags |= ACPI_BUILD_SSDT_PM;
> +    if ( !strncmp(xenstore_read("platform/acpi_s3", "1"), "1", 1)  )
> +        config->table_flags |= ACPI_BUILD_SSDT_S3;
> +    if ( !strncmp(xenstore_read("platform/acpi_s4", "1"), "1", 1)  )
> +        config->table_flags |= ACPI_BUILD_SSDT_S4;

I think that both here and at the consuming side this would look
better if you used bit fields. But even in its current form
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel