Re: [Xen-devel] [PATCH v2 1/5] xen/console: consolidate log levels to an array

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Mon, Jul 04, 2016 at 04:13:22PM +0100, Wei Liu wrote:
> It cleaner than open-coding strings and numbers. The array will also
> become handy later when we need to refactor things a bit.
> 
> No functional change.
> 
> Signed-off-by: Wei Liu <wei.liu2@xxxxxxxxxx>
> ---
> Cc: Jan Beulich <jbeulich@xxxxxxxx>
> ---
>  xen/drivers/char/console.c | 25 +++++++++++++++++++------
>  1 file changed, 19 insertions(+), 6 deletions(-)
> 
> diff --git a/xen/drivers/char/console.c b/xen/drivers/char/console.c
> index 650035d..6620a1c 100644
> --- a/xen/drivers/char/console.c
> +++ b/xen/drivers/char/console.c
> @@ -139,6 +139,20 @@ custom_param("guest_loglvl", parse_guest_loglvl);
>  
>  static atomic_t print_everything = ATOMIC_INIT(0);
>  
> +struct log_level {
> +    const char *str;
> +    unsigned int num;

This should be int instead of unsigned int.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel