Re: [Xen-devel] [PATCH v2 11/17] libxl/arm: Construct ACPI DSDT table

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 07/01/2016 06:18 AM, Julien Grall wrote:
> Hi Shannon,
>
> On 01/07/16 08:58, Shannon Zhao wrote:
>> On 2016/6/30 2:58, Boris Ostrovsky wrote:
>>> git://oss.oracle.com/git/bostrovs/xen.git:acpi_v1_wip
>> Hi Boris,
>>
>> Thanks a lot!
>> While I found there is a compiling problem of the last patch.
>>
>> undefined reference to `libxl__dom_load_acpi'
>> collect2: error: ld returned 1 exit status
>>
>> I think you should define the corresponding function for ARM.
>
> And this function should contain arch in the name to show it is
> arch-specific.
>
> However, I am not sure why
> libxl__arch_domain_{init,finalize}_hw_description were not re-used.


Haven't thought about those, I might be able to do that (finalize is the
likely place).


>
>>
>> Julien, Stefano,
>>
>> Looks like Boris is going to use libxl__dom_load_acpi to load ACPI
>> tables, do we need to use it for ARM as well or load the tables in
>> xc_dom_build_image()?
>
> I gave a quick look to the code and it is very similar to ARM for the
> allocation of the memory and copying the ACPI tables. So we may want
> to share some bits here.
>
> I have the feeling it would be better to do it in libxc where all the
> guest memory is handled. But I will let the tools maintainers decide
> where this should be done.

Haven't we decided that libxl is the better place?

-boris




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel