[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 8/8] minor #include change



>>> On 01.07.16 at 09:02, <czuzu@xxxxxxxxxxxxxxx> wrote:
> On 7/1/2016 9:56 AM, Razvan Cojocaru wrote:
>> On 06/30/16 21:47, Corneliu ZUZU wrote:
>>> --- a/xen/arch/x86/hvm/monitor.c
>>> +++ b/xen/arch/x86/hvm/monitor.c
>>> @@ -26,6 +26,7 @@
>>>   #include <asm/hvm/monitor.h>
>>>   #include <asm/monitor.h>
>>>   #include <asm/vm_event.h>
>>> +#include <asm/paging.h>
>>>   #include <public/vm_event.h>
>> If this #include is not required to be exactly where it is, I believe
>> alphabetical order is preferred (so #include <asm/paging.h> would be
>> above #include <asm/vm_event.h>).
> 
> Didn't know that was the rule, ack.

The fundamental idea being that conflicts between patches are more
likely when everyone just adds to the end of a group.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel

 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.