Re: [Xen-devel] [PATCH 4/8] x86/vm-event/monitor: turn monitor_write_data.do_write into enum

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 06/30/16 21:44, Corneliu ZUZU wrote:
> After trapping a control-register write vm-event and -until- deciding if that
> write is to be permitted or not (VM_EVENT_FLAG_DENY) and doing the actual 
> write,
> there cannot and should not be another trapped control-register write event.
> That is, currently -only one- of the fields of monitor_write_data.do_write can
> be true at any given moment and therefore it would be more appropriate to
> replace those fields with an enum value.
> 
> Signed-off-by: Corneliu ZUZU <czuzu@xxxxxxxxxxxxxxx>
> ---
>  xen/arch/x86/hvm/hvm.c       | 18 +++++++++++-------
>  xen/arch/x86/monitor.c       | 37 ++++++++++++++++++-------------------
>  xen/arch/x86/vm_event.c      | 25 ++-----------------------
>  xen/include/asm-x86/domain.h | 20 ++++++++++----------
>  4 files changed, 41 insertions(+), 59 deletions(-)

I'm not sure why neither Tamas' or my email address are in the CC list
(I would have assumed either monitor.c or vm_event.c would trigger a
response from get_maintainters.pl). In any case:

Acked-by: Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>


Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel