Re: [Xen-devel] [PATCH v5 07/17] xen: Use a typesafe to define INVALID_GFN

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/06/16 17:17, Julien Grall wrote:
> diff --git a/xen/arch/x86/hvm/hvm.c b/xen/arch/x86/hvm/hvm.c
> index a929e3b..b9ffce2 100644
> --- a/xen/arch/x86/hvm/hvm.c
> +++ b/xen/arch/x86/hvm/hvm.c
> @@ -5298,7 +5298,7 @@ static int do_altp2m_op(
>               a.u.enable_notify.vcpu_id != curr->vcpu_id )
>              rc = -EINVAL;
>  
> -        if ( (gfn_x(vcpu_altp2m(curr).veinfo_gfn) != INVALID_GFN) ||
> +        if ( (!gfn_eq(vcpu_altp2m(curr).veinfo_gfn,  INVALID_GFN)) ||

You can drop a set of brackets here, and the double space before
INVALID_GFN.

Otherwise, Reviewed-by: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel