Re: [Xen-devel] [PATCH V2 10/10] arm/vgic: Change fixed number of mmio handlers to variable number

[Julien Grall <julien.grall@xxxxxxx>]

Hi Shanker,

On 27/06/16 16:02, Shanker Donthineni wrote:
> On 06/27/2016 08:35 AM, Julien Grall wrote:
> > Hi Shanker,
> >
> > On 26/06/16 18:48, Shanker Donthineni wrote:
> > > diff --git a/xen/include/asm-arm/domain.h b/xen/include/asm-arm/domain.h
> > > index 29346c6..b205461 100644
> > > --- a/xen/include/asm-arm/domain.h
> > > +++ b/xen/include/asm-arm/domain.h
> > > @@ -111,6 +111,7 @@ struct arch_domain
> > >           int nr_regions;                     /* Number of rdist regions
> > */
> > >           uint32_t rdist_stride;              /* Re-Distributor stride
> > */
> > >   #endif
> > > +        uint32_t mmio_count;                /* Number of mmio handlers
> > */
> >
> > Is it necessary to have this value part of the arch_domain? I.e Do we
> > need this value after the initialization? If not, then it might be
> > better to add a parameter to domain_vgic_register uint32_t *pointer.
> Absolutely, we don't need this variable after the domain build process.
> I have taken this approach to avoid too many code changes. Your
> suggestion requires changes to functions vgic_v2/v3_init() prototype for
> adding a new parameter.
The internal interface of Xen is not set in stone. We modify quite often 
to match our needs or for clean-up purpose.
I always welcome an interface changes as long as it makes sense.

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel