Re: [Xen-devel] [PATCH v12 4/6] IOMMU/x86: using a struct pci_dev* instead of SBDF

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On June 24, 2016 7:46 PM, Tian, Kevin <kevin.tian@xxxxxxxxx> wrote:
> > From: Xu, Quan
> > Sent: Friday, June 24, 2016 1:52 PM
> >
> > From: Quan Xu <quan.xu@xxxxxxxxx>
> >
> > a struct pci_dev* instead of SBDF is stored inside struct pci_ats_dev
> > and parameter to enable_ats_device().
> >
> > Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> 
> Can we unify the naming convention throughout the patch, e.g.
> always using ats_pdev for "struct pci_ats_dev" variable, while pdev for 
> "struct
> pci_dev". It's quite confusing when reading the patch which has both named
> as pdev in various places.... I know the confusion is also in original code, 
> but
> please take this chance to clean them up. :-)

Make sense. I'll fix it in next patch soon.

Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel