Re: [Xen-devel] [PATCH v3 6/8] xen: Use the typesafe mfn and gfn in map_mmio_regions...

[Stefano Stabellini <sstabellini@xxxxxxxxxx>]

On Thu, 23 Jun 2016, Julien Grall wrote:
> On 23/06/16 15:05, Stefano Stabellini wrote:
> > > diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
> > > index aa4e774..47cb383 100644
> > > --- a/xen/arch/arm/p2m.c
> > > +++ b/xen/arch/arm/p2m.c
> > > @@ -1245,27 +1245,27 @@ int unmap_regions_rw_cache(struct domain *d,
> > >   }
> > > 
> > >   int map_mmio_regions(struct domain *d,
> > > -                     unsigned long start_gfn,
> > > +                     gfn_t start_gfn,
> > >                        unsigned long nr,
> > > -                     unsigned long mfn)
> > > +                     mfn_t mfn)
> > >   {
> > >       return apply_p2m_changes(d, INSERT,
> > > -                             pfn_to_paddr(start_gfn),
> > > -                             pfn_to_paddr(start_gfn + nr),
> > > -                             pfn_to_paddr(mfn),
> > > +                             pfn_to_paddr(gfn_x(start_gfn)),
> > > +                             pfn_to_paddr(gfn_x(start_gfn) + nr),
> > > +                             pfn_to_paddr(mfn_x(mfn)),
> > >                                MATTR_DEV, 0, p2m_mmio_direct,
> > >                                d->arch.p2m.default_access);
> > 
> > Any reason why you didn't push these changes down to apply_p2m_changes too?
> 
> To keep this series simple. I have another series coming up to push the change
> down to apply_p2m_changes and clean up the P2M code.
> 
> I can move the patch to push down the change in this series if you prefer.

Yeah, it makes sense to keep them together.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel