Re: [Xen-devel] [PATCH v2] xen: arm: Update arm64 image header

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >>Please check the _existing_ code: It's
> >>
> >>
> >>if ( zimage.magic0 != ZIMAGE64_MAGIC_V0 &&
> >>      zimage.magic1 != ZIMAGE64_MAGIC_V1 )
> >>   return -EINVAL;
> 
> It is an "&&" not "||". So it will fail only if none of the 2 magics are
> present.
> 

Argh. Brainfart!

> >Oh, indeed!
> >>
> >>
> >>My patch doesn't change anything regarding the fact that if the magics are
> >>not valid (due to quite old kernel version) the code does exit with an
> >>error.
> >
> >/me nods
> >>
> >>While the review of v1 of this patch, Julien asked for an error message to
> >>be added here. Fine.
> >>
> >>But if there is the request to change the behavior regarding which kernels
> >>are supported I'd think that this is independent on this patch and should be
> >>done in an additional patch.
> >
> >Right, and I think it is fine to skip that  - because as you say - it
> >already ignores older kernels.
> 
> This is not right. The current version of Xen is not ignoring older kernels.
> 
> The current check allows kernels with only MAGIC_V0 (any Linux older than
> 3.12) to be detected by Xen.
> 
> However, this is impacting only one version because support for Xen on ARM64
> was added in Linux 3.11.

And you ARM maintainers are OK ditching that support?

It probably also means updating some Wiki page and docs.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel