Re: [Xen-devel] [PATCH 13/17] xen: move FLASK entry under XSM in Kconfig

[Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>]

On 06/20/2016 10:46 AM, Doug Goldstein wrote:
> On 6/20/16 9:04 AM, Daniel De Graaf wrote:
> > Since enabling XSM is required to enable FLASK, place the option for
> > FLASK below the one for XSM.  In addition, since it does not make sense
> > to enable XSM without any XSM providers, and FLASK is the only XSM
> > provider, hide the option to disable FLASK under EXPERT.
> >
> > Signed-off-by: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
> > ---
> > @@ -137,6 +119,25 @@ config XSM
> >
> >           If unsure, say N.
> >
> > +config FLASK
> > +       def_bool y
> > +       bool "FLux Advanced Security Kernel support" if EXPERT = "y"
> Ok. Here's the real review. I think you want the prompt to be optional
> if EXPERT is enabled then I think you need to use "prompt" instead of
> "bool". You've already got this set to a bool with the "def_bool" line.
OK.  This version also apparently works, since I tested it, but if
prompt is the preferred keyword I'll change it.

--
Daniel De Graaf
National Security Agency

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel