Re: [Xen-devel] [PATCH v2 2/2] xen: make available hvm_fep to non-debug build as well

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 17.06.16 at 16:44, <wei.liu2@xxxxxxxxxx> wrote:
> On Fri, Jun 17, 2016 at 08:40:40AM -0600, Jan Beulich wrote:
>> >>> On 17.06.16 at 16:32, <wei.liu2@xxxxxxxxxx> wrote:
>> > On Fri, Jun 17, 2016 at 08:28:34AM -0600, Jan Beulich wrote:
>> >> >>> On 17.06.16 at 15:51, <andrew.cooper3@xxxxxxxxxx> wrote:
>> >> > On 17/06/16 12:34, Jan Beulich wrote:
>> >> >>>>> On 17.06.16 at 13:05, <wei.liu2@xxxxxxxxxx> wrote:
>> >> >>> --- a/xen/arch/x86/Kconfig
>> >> >>> +++ b/xen/arch/x86/Kconfig
>> >> >>> @@ -59,6 +59,20 @@ config BIGMEM
>> >> >>>  
>> >> >>>         If unsure, say N.
>> >> >>>  
>> >> >>> +config HVM_FEP
>> >> >>> +     bool "HVM Forced Emulation Prefix support"
>> >> >> And no "if EXPERT"?
>> >> > 
>> >> > Is that wise? Does that mean we get a default on option which can't be
>> >> > selected in menuconfig?
>> >> 
>> >> Oh, that's true. The default should be off in any event.
>> >> 
>> > 
>> > So it depends on config EXPERT, defaults to off.
>> > 
>> > Fine by me in any event, just need a final decision and I will make the
>> > change.
>> 
>> One more adjustment: I guess it should default to DEBUG, to retain
>> current behavior.
>> 
> 
> I think I wrote this series to make this feature available to non-debug
> builds.  I don't really get the rationale behind this request. Did you
> change your mind during the last few days?

Making it available doesn't mean enable it by default for everyone.
People wanting it in non-debug builds should be able to get it, but
unaware people shouldn't be caught by surprise. (And btw.,
defaulting it to DEBUG is a relaxation over defaulting it to off.)

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel