Re: [Xen-devel] [PATCH 3/7] vm-event: introduce vm_event_vcpu_enter

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.06.16 at 16:08, <czuzu@xxxxxxxxxxxxxxx> wrote:
> @@ -509,6 +508,8 @@ void hvm_do_resume(struct vcpu *v)
>          }
>      }
>  
> +    vm_event_vcpu_enter(v);

Why here?

> @@ -3874,6 +3875,9 @@ void vmx_vmenter_helper(const struct cpu_user_regs 
> *regs)
>      }
>  
>   out:
> +    if ( guest_mode(regs) )
> +        vm_event_vcpu_enter(curr);
> +
>      HVMTRACE_ND(VMENTRY, 0, 1/*cycles*/, 0, 0, 0, 0, 0, 0, 0);
>  
>      __vmwrite(GUEST_RIP,    regs->rip);

Why with a conditional? The registers can't possibly hold to non-
guest state when you're here.

> --- a/xen/arch/x86/mm/p2m.c
> +++ b/xen/arch/x86/mm/p2m.c
> @@ -36,7 +36,6 @@
>  #include <asm/hvm/nestedhvm.h>
>  #include <asm/altp2m.h>
>  #include <asm/hvm/svm/amd-iommu-proto.h>
> -#include <asm/vm_event.h>
>  #include <xsm/xsm.h>

There are way too many of these #include adjustments here. If
you really mean to clean these up, please don't randomly throw
this into various unrelated patches.

> --- a/xen/common/monitor.c
> +++ b/xen/common/monitor.c
> @@ -22,8 +22,8 @@
>  #include <xen/monitor.h>
>  #include <xen/sched.h>
>  #include <xsm/xsm.h>
> +#include <xen/vm_event.h>
>  #include <asm/monitor.h>
> -#include <asm/vm_event.h>

Please retain at least basic grouping (i.e. all xen/ ones together,
meaning the insertion should move up by one line).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel