Re: [Xen-devel] [PATCH RFC 2/2] xen: make available hvm_fep to non-debug build as well

[Doug Goldstein <cardoe@xxxxxxxxxx>]

On 6/15/16 9:47 AM, Wei Liu wrote:
> On Wed, Jun 15, 2016 at 09:39:24AM -0500, Doug Goldstein wrote:
>> On 6/15/16 9:31 AM, Wei Liu wrote:
> [...]
>>> -#ifndef NDEBUG
>>>  /* Permit use of the Forced Emulation Prefix in HVM guests */
>>>  extern bool_t opt_hvm_fep;
>>> -#else
>>> -#define opt_hvm_fep 0
>>> -#endif
>>
>> Please instead add this as a Kconfig option and you can default it to
>> enabled.
>>
> 
> Sure, it is reasonable that you want to compile this out.
> 
> But which section does it belong to? Architecture Features I guess?
> 
> Wei.
> 

That sounds reasonable to me. You can add it to arch/Kconfig if it makes
sense for both ARM and x86.

-- 
Doug Goldstein

Attachment: signature.asc
Description: OpenPGP digital signature

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel