Re: [Xen-devel] [PATCH v2 1/1] tools/livepatch: cleanup unnecessary "j = ARRAY_SIZE(action_options); "

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Wed, Jun 15, 2016 at 11:04:40AM +0200, Olaf Hering wrote:
> On Wed, Jun 15, Wei Liu wrote:
> 
> > To fix the breakage, please check out staging branch and write a patch
> > to fix it. And maybe the commit message should say something like
> > "initialise j to 0 to make some versions of gcc happy".
> 
> Not "some", but rather "at least gcc4.5/4.3" or similar.
> There are already enough "some"s out there, where in the end noone knows
> what the given workaround is all about.
> 

Fine by me of course. I didn't have a list of known offenders so I
couldn't suggest concrete version numbers.

Wei.

> Olaf

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel