Re: [Xen-devel] [PATCH v8 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping (top level ones)

["Xu, Quan" <quan.xu@xxxxxxxxx>]

On June 13, 2016 11:17 PM, Xu, Quan <quan.xu@xxxxxxxxx> wrote:
> From: Quan Xu <quan.xu@xxxxxxxxx>
> 
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
> Acked-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
> 
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> CC: Feng Wu <feng.wu@xxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
> CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
> 
> v8: use the Linux coding style for arm code.
> ---
>  xen/drivers/passthrough/arm/smmu.c            | 4 ++--
>  xen/drivers/passthrough/vtd/iommu.c           | 7 ++++---
>  xen/include/asm-x86/hvm/svm/amd-iommu-proto.h | 4 ++--
>  xen/include/xen/iommu.h                       | 4 ++--
>  4 files changed, 10 insertions(+), 9 deletions(-)
> 
> diff --git a/xen/drivers/passthrough/arm/smmu.c
> b/xen/drivers/passthrough/arm/smmu.c
> index 1ce4ddf..58fde32 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2745,8 +2745,8 @@ static void
> arm_smmu_iommu_domain_teardown(struct domain *d)
>       xfree(xen_domain);
>  }
> 
> -static int arm_smmu_map_page(struct domain *d, unsigned long gfn,
> -                          unsigned long mfn, unsigned int flags)
> +static int __must_check arm_smmu_map_page(struct domain *d, unsigned
> long gfn,
> +                     unsigned long mfn, unsigned int flags)
>  {
>       p2m_type_t t;
> 

Julien,

Could you help me review this patch? This patch still needs your ack if I have 
fixed coding style.
Thanks in advance.

Quan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel