Re: [Xen-devel] [PATCH v2 2/3] libxl: update vcpus bitmap in retrieved guest config

[Wei Liu <wei.liu2@xxxxxxxxxx>]

On Tue, Jun 14, 2016 at 11:47:57AM +0100, Anthony PERARD wrote:
[...]
> > > > +
> > > >  int libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid,
> > > >                                          libxl_domain_config *d_config)
> > > >  {
> > > > @@ -7270,6 +7317,46 @@ int 
> > > > libxl_retrieve_domain_configuration(libxl_ctx *ctx, uint32_t domid,
> > > >          libxl_dominfo_dispose(&info);
> > > >      }
> > > >  
> > > > +    /* VCPUs */
> > > > +    {
> > > > +        libxl_bitmap *map = &d_config->b_info.avail_vcpus;
> > > > +        unsigned int max_vcpus = d_config->b_info.max_vcpus;
> > > > +
> > > > +        libxl_bitmap_dispose(map);
> > > > +        libxl_bitmap_init(map);
> > > > +        libxl_bitmap_alloc(CTX, map, max_vcpus);
> > > > +        libxl_bitmap_set_none(map);
> > > > +
> > > > +        switch (d_config->b_info.type) {
> > > > +        case LIBXL_DOMAIN_TYPE_HVM:
> > > > +            switch (d_config->b_info.device_model_version) {
> > > > +            case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> > > > +                rc = libxl__update_avail_vcpus_qmp(gc, domid,
> > > > +                                                   max_vcpus, map);
> > > > +                break;
> > > > +            case LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN_TRADITIONAL:
> > > > +            case LIBXL_DEVICE_MODEL_VERSION_NONE:
> > > > +                rc = libxl__update_avail_vcpus_xenstore(gc, domid,
> > > > +                                                        max_vcpus, 
> > > > map);
> > > > +                break;
> > > > +            default:
> > > > +            abort();
> > > 
> > > Missing indentation for abort.
> > > 
> > 
> > Will fix.
> > 
> > > Also, that is where xl abort on migration.
> > > 
> > 
> > Hmm...  This means the device model version is not valid (unknown?).
> > 
> > Can you paste in your guest config?
> 
> With all commented line removed:
> 
> builder = 'hvm'
> memory = 500
> vcpus = 2
> maxvcpus = 6
> name = "arch"
> vif = [ 'type=ioemu,mac=00:16:3e:XX:XX:XX' ]
> disk = [
> 'phy:/dev/vg42/guest_arch64,hda,w',
>  'file:/root/vm/iso/archlinux-2014.04.01-dual.iso,hdc:cdrom,r',
> ]
> device_model_args_hvm = [
> ]
> usbdevice='tablet'
> boot="cd"
> serial='pty'
> sdl = 0
> vnc = 1
> vnclisten = '0.0.0.0'
> vncunused = 1
> spice=0
> uuid = "XXXX"
> 

This means your device model version is LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN
so it should be covered by the correct case.

I'm confused.

Wei.

> 
> -- 
> Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel