Re: [Xen-devel] [PATCH v8 02/11] IOMMU/MMU: enhance the call trees of IOMMU unmapping and mapping

["Jan Beulich" <jbeulich@xxxxxxxx>]

>>> "Xu, Quan" <quan.xu@xxxxxxxxx> 06/13/16 5:22 PM >>>
>From: Quan Xu <quan.xu@xxxxxxxxx>
>
>When IOMMU mapping is failed, we issue a best effort rollback, stopping
>IOMMU mapping, unmapping the previous IOMMU maps and then reporting the
>error up to the call trees. When rollback is not feasible (in early
>initialization phase or trade-off of complexity) for the hardware domain,
>we do things on a best effort basis, only throwing out an error message.
>
>IOMMU unmapping should perhaps continue despite an error, in an attempt
>to do best effort cleanup.
>
>Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
>Reviewed-by: Jan Beulich <jbeulich@xxxxxxxx>
>Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
>Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>
>CC: Jan Beulich <jbeulich@xxxxxxxx>
>CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
>CC: Jun Nakajima <jun.nakajima@xxxxxxxxx>
>CC: Kevin Tian <kevin.tian@xxxxxxxxx>
>CC: George Dunlap <george.dunlap@xxxxxxxxxxxxx>
>CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
>CC: Feng Wu <feng.wu@xxxxxxxxx>
>
>v8:
>1. add missing blank
>2. add a brief comment (Jan, if you have a better one, could you help me
>enhance it upon commit?)

This _still_ sits above the first --- separator, despite you having been asked 
more
than once to move it down.

As to question 2, I'll see what I can do (I'm specifically not very happy that 
this
comment which you added in more than one place isn't really "brief"). And before
the patch can be committed, it'll need George's ack anyway.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel