| [Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
 Re: [Xen-devel] [PATCH v7 07/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU suspending (top level ones)
 
To: "Xu, Quan" <quan.xu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxx>From: Suravee Suthikulanit <suravee.suthikulpanit@xxxxxxx>Date: Thu, 9 Jun 2016 13:58:54 -0500Cc: Kevin Tian <kevin.tian@xxxxxxxxx>, Stefano Stabellini <sstabellini@xxxxxxxxxx>, Keir Fraser <keir@xxxxxxx>, Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>, dario.faggioli@xxxxxxxxxx, Julien Grall <julien.grall@xxxxxxx>, Jan Beulich <jbeulich@xxxxxxxx>, Andrew Cooper <andrew.cooper3@xxxxxxxxxx>, Feng Wu <feng.wu@xxxxxxxxx>Delivery-date: Thu, 09 Jun 2016 18:59:08 +0000List-id: Xen developer discussion <xen-devel.lists.xen.org>Spamdiagnosticmetadata: NSPMSpamdiagnosticoutput: 1:99 
 
On 6/8/2016 3:59 AM, Xu, Quan wrote:
 
From: Quan Xu <quan.xu@xxxxxxxxx>
Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
CC: Jan Beulich <jbeulich@xxxxxxxx>
CC: Liu Jinsong <jinsong.liu@xxxxxxxxxxxxxxx>
CC: Keir Fraser <keir@xxxxxxx>
CC: Andrew Cooper <andrew.cooper3@xxxxxxxxxx>
CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
CC: Julien Grall <julien.grall@xxxxxxx>
CC: Kevin Tian <kevin.tian@xxxxxxxxx>
CC: Feng Wu <feng.wu@xxxxxxxxx>
v7:
  1. return SAVED_ALL at the bottom of device_power_down(), instead
     of SAVED_NONE.
  2. drop the 'if ( error > 0 )', calling device_power_up(error)
     without any if().
  3. for vtd_suspend():
       - drop pointless initializer.
       - return 0 at the bottom to make obvious that no error path
         comes there.
 
Shouldn't the changes log for v7 probably go ...
 
---
 
... HERE instead so that we don't get this in the commit log.
For AMD part,
Acked-by: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
Thanks,
Suravee
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel
 
 |