Re: [Xen-devel] [PATCH v7 04/11] IOMMU: propagate IOMMU Device-TLB flush error up to IOMMU mapping (top level ones)

[Julien Grall <julien.grall@xxxxxxx>]

Hello,

On 08/06/16 09:58, Xu, Quan wrote:
> From: Quan Xu <quan.xu@xxxxxxxxx>
>
> Signed-off-by: Quan Xu <quan.xu@xxxxxxxxx>
> Acked-by: Kevin Tian <kevin.tian@xxxxxxxxx>
>
> CC: Suravee Suthikulpanit <suravee.suthikulpanit@xxxxxxx>
> CC: Stefano Stabellini <sstabellini@xxxxxxxxxx>
> CC: Julien Grall <julien.grall@xxxxxxx>
> CC: Kevin Tian <kevin.tian@xxxxxxxxx>
> CC: Feng Wu <feng.wu@xxxxxxxxx>
> CC: Jan Beulich <jbeulich@xxxxxxxx>
>
> v7: drop the amd_iommu_hwdom_init() fix, which has been added in
>      patch 2 in this v7.
> ---
>   xen/drivers/passthrough/arm/smmu.c            | 4 ++--
>   xen/drivers/passthrough/vtd/iommu.c           | 7 ++++---
>   xen/include/asm-x86/hvm/svm/amd-iommu-proto.h | 4 ++--
>   xen/include/xen/iommu.h                       | 4 ++--
>   4 files changed, 10 insertions(+), 9 deletions(-)
>
> diff --git a/xen/drivers/passthrough/arm/smmu.c 
> b/xen/drivers/passthrough/arm/smmu.c
> index 1ce4ddf..ee5c89d 100644
> --- a/xen/drivers/passthrough/arm/smmu.c
> +++ b/xen/drivers/passthrough/arm/smmu.c
> @@ -2745,8 +2745,8 @@ static void arm_smmu_iommu_domain_teardown(struct domain 
> *d)
>         xfree(xen_domain);
>   }
>
> -static int arm_smmu_map_page(struct domain *d, unsigned long gfn,
> -                            unsigned long mfn, unsigned int flags)
> +static int __must_check arm_smmu_map_page(struct domain *d, unsigned long gfn,
> +                                          unsigned long mfn, unsigned int 
> flags)
This file is using the Linux coding style. So you should use hard tab here.

>   {
>         p2m_type_t t;
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel