Re: [Xen-devel] [PATCH v3 09/16] xen/arm: Introduce alternative runtime patching

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> >>diff --git a/xen/arch/arm/xen.lds.S b/xen/arch/arm/xen.lds.S
> >>index 1f010bd..495f9d8 100644
> >>--- a/xen/arch/arm/xen.lds.S
> >>+++ b/xen/arch/arm/xen.lds.S
> >>@@ -129,6 +129,9 @@ SECTIONS
> >>        _sinittext = .;
> >>        *(.init.text)
> >>        _einittext = .;
> >>+#ifdef CONFIG_ALTERNATIVE
> >>+       *(.altinstr_replacement)
> >>+#endif
> >
> >This is outside the _einittext? x86 looks to have .altinstr_replacement
> >inside the _einittext.
> 
> Yes, I looked at the x86 code when I did the implement and I did not find
> any good reason to keep .altinstr_replace inside the inittext.
> 
> altinstr_replacement contains replacement instructions. Anything inside the
> inittext region will be mark executable, which is not what we want here.

Right, but we don't this code after the bootup (as in we patch the
.text and we can eject the .altinstr_replacement).

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel