Re: [Xen-devel] [PATCH RESEND 00/14] Xen ARM DomU ACPI support

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 06/07/2016 06:54 AM, Julien Grall wrote:
> Hello Boris,
>
> On 06/06/16 17:50, Boris Ostrovsky wrote:
>> On 06/06/2016 11:37 AM, Boris Ostrovsky wrote:
>>>> What I don't want to see is that x86 builds its ACPI table in libxc
>>>> while ARM builds its in libxl. That would make future merger harder.
>>>>
>>>> Boris?
>>> TBH, I am not sure which library this should really belong to. I felt
>>> libxc would be more appropriate.
>>
>> Actually, I now remember why I picked libxc: because I wanted ACPI pages
>> to be loaded as part of xc_dom_build_image().
>
> What about adding a new field in xc_dom_image? For the device tree,
> libxl is provide a buffer which will be loaded as part of
> xc_dom_build_image (see devicetree_blob).

Yes, I think we can do this (although I suspect we will need more than
one field there).

Still, we need first to understand where this code should live logically
(i.e. is this the type of things that libxl does or is it the type of
things that libxc does) instead of trying to see where we can jam it.

(And only then we will argue that we can't put it in that logical place
due to whatever excuses we can come up with ;-) )

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel