Re: [Xen-devel] [PATCH V6 1/3] drivers/pl011: Don't configure baudrate

[Julien Grall <julien.grall@xxxxxxx>]

Hello Shanker,

On 06/06/16 23:58, Shanker Donthineni wrote:
> The default baud and clock_hz configuration parameters are hardcoded
> (commit 60ff9444480995008caf) for Versatile Express. Other platforms,
> these default values may not be valid and might cause problems by
> programming registers IBRD and FBRD incorrectly.
>
> So, removing driver logic that sets the baudrate to fix the problem.
> The boot firmware is responsible for setting the correct baudrate.
It might be worth to say that the behavior is unchanged because the 
driver was already relying on the boot firmware.
Other than that:

Reviewed-by: Julien Grall <julien.grall@xxxxxxx>

Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel