Re: [Xen-devel] [PATCH v3] arm/acpi: Add Server Base System Architecture UART support

[Julien Grall <julien.grall@xxxxxxx>]

On 06/06/2016 20:55, Shanker Donthineni wrote:
> On 06/06/2016 11:04 AM, Julien Grall wrote:
> > On 03/06/16 18:39, Shanker Donthineni wrote:
> > > The ARM Server Base System Architecture describes a generic UART
> > > interface. It doesn't support clock control registers, modem
> > > control, DMA and hardware flow control features. So, extend the
> > > driver probe() to handle SBSA interface and skip the accessing
> > > PL011 registers that are not described in SBSA document
> > > (ARM-DEN-0029 Version 3.0, 6 APPENDIX B: GENERIC UART).
> > >
> > > Signed-off-by: Shanker Donthineni <shankerd@xxxxxxxxxxxxxx>
> > > ---
> > > Changes since v2:
> > >     Edited commit text to include SBSA document version.
> > >     Remove setting baudrate code completely as per Julien's suggestion.
> > This item and ...
> >
> > >     Support both the SBSA interface types ACPI_DBG2_SBSA &
> > ACPI_DBG2_SBSA_32.
> > >     Replace MIS references with combination of RIS & IMSC.
> > this one need some description in the commit message to explain why it is fine 
> > for non-SBSA UART to do it.
> I have not tested this patch on non-SBSA UART platform, let me apply this 
> change only for SBSA UART driver
> for safe side.
This patch could be easily tested on the foundation model. I don't want 
to see "if SBSA UART" in the interrupt handler. The code there should be 
straight-forward.
What I am asking for is explaining in a commit message why MIS could be 
replaced by RIS & IMSC. You must have read the doc to find that.
A comment in the code to say this necessary to be SBSA compliant v2.x 
would be good to avoid change reverting back in the future to MIS.
Regards,

--
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel