Re: [Xen-devel] [PATCH RFC 06/20] acpi/hvmloader: Collect processor and NUMA info in hvmloader

[Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx>]

On 06/03/2016 08:16 AM, Jan Beulich wrote:
>>>> On 02.06.16 at 19:18, <boris.ostrovsky@xxxxxxxxxx> wrote:
>> On 06/02/2016 10:05 AM, Jan Beulich wrote:
>>>>>> On 06.04.16 at 03:25, <boris.ostrovsky@xxxxxxxxxx> wrote:
>>>> @@ -485,6 +494,10 @@ struct acpi_config {
>>>>          unsigned long acpi_pt_addr;
>>>>          uint32_t acpi_pt_length;
>>>>      } pt;
>>>> +    uint32_t nr_vcpus;
>>>> +    uint8_t  *vcpu_online;
>>>> +    int apic_mode;
>>> Instead of copying those fields, how about simply adding a pointer
>>> to struct hvm_info_table here?
>>>
>>>> +    struct acpi_numa numa;
>>> Same for this one - perhaps better a pointer, and an instance of the
>>> structure could then replace all those individual global variables.
>>>
>>>> @@ -910,6 +911,16 @@ void hvmloader_acpi_build_tables(struct acpi_config 
>>>> *config,
>>>>      if ( !strncmp(xenstore_read("platform/acpi_s4", "1"), "1", 1)  )
>>>>          config->table_flags |= ACPI_BUILD_SSDT_S4;
>>>>  
>>>> +    config->nr_vcpus = hvm_info->nr_vcpus;
>>>> +    config->vcpu_online = hvm_info->vcpu_online;
>>>> +    config->apic_mode = 1;
>>> Why is this a hard coded 1? It was hvm_info->apic_mode before.
>> I think that's because hvm_info is initialized in libxl very late, after
>> ACPI is already set. Let me see whether there was a reason for this
>> order and if there wasn't then yes, I can point to hvm_info.
> No matter when libxl initializes hvm_info, it necessarily happens
> before the guest starts. And we're inside the running guest here.

At this point -- yes. However, this is (partly) done in preparation to
making this code available to libxc for building HVMlite guests, so this
will run before the guest has started.

In any case, I suspect I may be able to move ACPI building in libxl to
after hvm_info is initialized.

-boris


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel